Re: [patch 17/18] scsi: select CRC_T10DIF only when necessary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-08-21 at 10:01 -0400, Martin K. Petersen wrote:
> -	select CRC_T10DIF
> +	select CRC_T10DIF if BLK_DEV_INTEGRITY
> 
> Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

Actually, I don't think this is right at all.

This is a purely cosmetic fix and the tip of the iceberg.  If not
compiling in the integrity code matters on grounds of kernel bloat, and
I think it does, then the correct fix is to make sure none of it
compiles into SD if BLK_DEV_INTEGRITY isn't set.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux