On Wed, 23 Jul 2008 18:11:58 -0700 "Dan Williams" <dan.j.williams@xxxxxxxxx> wrote: > On Thu, Jun 26, 2008 at 7:36 AM, FUJITA Tomonori > <fujita.tomonori@xxxxxxxxxxxxx> wrote: > >> Jens can we add merge this for .27 or does anyone still has objections? > > > > I think that this patch makes sg's permission stricter. So this could > > break the existing user-space applications. > > Yes, it seems to have broken a simple routine I had to retrieve the > disk serial number from /dev/sg0. Works fine if I run the ioctl on > /dev/sda. > > Can we consider this a regression or am I doing something wrong? The > following returns 2 on post-2.6.26 mainline and 0 otherwise. This is a regression. Obviously, the filter patch was tested with only the block SG_IO partly. It breaks sg and bsg. Al Viro pointed out: http://marc.info/?l=linux-kernel&m=121662171123285&w=2 I think that it breaks even the block SG_IO with tape drives. I'll send fixes tonight. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
