* Brian King (brking@xxxxxxxxxxxxxxxxxx) wrote:
> Robert Jennings wrote:
> > @@ -1613,6 +1624,26 @@ static struct scsi_host_template driver_
> > };
> >
> > /**
> > + * ibmvscsi_get_desired_dma - Calculate IO entitlement needed by the driver
> > + *
> > + * @vdev: struct vio_dev for the device whose entitlement is to be returned
> > + *
> > + * Return value:
> > + * Number of bytes of IO data the driver will need to perform well.
> > + */
> > +static unsigned long ibmvscsi_get_desired_dma(struct vio_dev *vdev)
> > +{
> > + /* iu_storage data allocated in initialize_event_pool */
> > + unsigned long io_entitlement = max_requests * sizeof(union viosrp_iu);
>
> Since you are removing the use of "entitlement" in the function description,
> you should probably remove it everywhere in this patch.
I'll clean this up.
> > +
> > + /* add io space for sg data */
> > + io_entitlement += (IBMVSCSI_MAX_SECTORS_DEFAULT *
> > + IBMVSCSI_CMDS_PER_LUN_DEFAULT);
> > +
> > + return IOMMU_PAGE_ALIGN(io_entitlement);
>
> I really think this function should just return the number of bytes and
> let the caller round it up to any boundary requirements it might have.
I agree. I'll be posting a new patch after a work out another issue I'm
having. Hope to have that out soon.
--Rob Jennings
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
