Re: [PATCH] sym53c8xx: Fix bogus sym_que_entry re-implementation of container_of

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-07-06 at 23:35 -0700, Grant Grundler wrote:
> > --- linux-work.orig/drivers/scsi/sym53c8xx_2/sym_misc.h 2008-07-07 10:42:03.000000000 +1000
> > +++ linux-work/drivers/scsi/sym53c8xx_2/sym_misc.h      2008-07-07 10:44:41.000000000 +1000
> > @@ -121,9 +121,7 @@ static __inline void sym_que_move(struct
> >        }
> >  }
> >
> > -#define sym_que_entry(ptr, type, member) \
> > -       ((type *)((char *)(ptr)-(unsigned int)(&((type *)0)->member)))
> > -
> > +#define sym_que_entry(ptr, type, member) container_of(ptr, type, member)
> 
> There are 11 uses of sym_que_entry() macro. Is that too many to
> completely remove it's use?
> (question for willy to decide I guess).

Willy wants to completely remove the queue management. While that might
be the right thing to do, I'd like the small fixup to go in to at least
remove the warnings in the meantime.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux