Hi Denys, Denys Vlasenko wrote:
Hi Hannes, aic7xxx still contains ~30kb of dead code if pretty printing of registers is requested. These patches deal with it. I did not get any feedback from you whether the approach of adding "dont_generate_debug_code" marker would be acceptable despite asking twice. I decided that it's a "Yes".
Well, yes. Sort of. Patches are okay in principle, only it would be best if you could hook the dont_generate_debug_code marker to the AIC79XX_DEBUG_ENABLE config option. This way anyone interested in doing sequencer debugging would still get the full sequencer code (which can be quite helpful at times). And it would be disabled for the unsuspecting user. Apart from this: well done. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
