Re: [patch 07/11] zfcp: Cleanup of code in zfcp_aux.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 01, 2008 at 03:44:13PM +0200, Swen Schillig wrote:
> > Sorry, but this still seems to be incorrect. strsep modifies the string that
> > gets passed to it. In this case you let it operate on the original module
> > parameter string which is also exported via sysfs.
> > So after parsing finished the exported string is much shorter than the
> > original string. That was actually the whole point why the old code allocated
> > memory and copied the string so the copy could be modified.
> > A comment would have been good ;)
> > --
> Correct,
> 
> I fixed the patch and Christof will send it soon to the list.

While testing this, i also fixed one issue with the erp patch. To
avoid confusion, i will resend the complete patch series later today.

Christof
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux