>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> writes: [Protection sgl alloc + init] James> I'm afraid you can't do it like this because it will violate James> our forward progress guarantees. If this is the last spare James> command required for writeout, you need to guarantee either James> this allocation will succeed, or we can proceed without the DIF James> data. We can't just turn off DIF -- that would violate the integrity guarantees. But I'll move the protection sgl to the host command pool. >> + if (inq_result[5] & 0x1) + sdev->protection = 1; James> Is there a reason to have a separate flag here Not really. I used to key off of sdp->protection quite a bit but I think the only place I use it now is during sd discovery. So this can simply go away... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html