On Fri, 2008-06-27 at 16:33 +0200, Hannes Reinecke wrote: > I cannot see how this _could_ fail, as this function is provided by > the module, so the very existence of the function depends on the > module. But maybe it's better to check, even so. > > I'll send an updated patch. Just because you're in the actual module it's not safe to assume try_module_get() will succeed. The modules have a state variable (->state) if the user tries to remove the module, this state check will fail in try_module_get() and it will actually return a failure. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
