>>>>> "Matthew" == Matthew Wilcox <matthew@xxxxxx> writes: Matthew> On Sun, Jun 22, 2008 at 10:41:35AM -0400, Martin K. Petersen wrote: >> + memset(cmd, 0, 16); + cmd[0] = INQUIRY; + cmd[1] = 1; /* EVPD */ >> + cmd[2] = page; /* VPD page */ + cmd[3] = len; Matthew> This looks like a bug to me. Yeah, what I meant was cmd[4] = len; Matthew> This isn't true for all pages. For example, 0x83 and 0x85 Matthew> have a length in buffer[2] and [3]. Fair enough. I only looked at b0 and b1. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html