Re: [PATCH] esp: tidy up target reference counting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-06-23 at 14:58 -0700, David Miller wrote:
> From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 23 Jun 2008 14:52:09 -0500
> 
> > The esp driver currently does hand rolled reference counting of its
> > target.  It's much easier to do what it needs to do if it's plugged into
> > the mid-layer callbacks (target_alloc and target_destroy) which were
> > designed for this case, so do it this way and get rid of the internal
> > target reference count.
> > 
> > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> 
> Much cleaner, thanks!
> 
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

You're welcome ... I actually initially queued this for the merge
window, but since this looks like it fixes a bug that would affect any
multi-lun installation, isn't it a candidate for the current git head
(and indeed for stable), or isn't there that much of a multi-lun install
base with this driver to worry about?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux