On Mon, 16 Jun 2008 07:49:49 +0200 "Adel Gadllah" <adel.gadllah@xxxxxxxxx> wrote: > 2008/6/16 FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>: > > On Sat, 14 Jun 2008 08:51:16 +0200 > > "Adel Gadllah" <adel.gadllah@xxxxxxxxx> wrote: > > > >> Attached a new version of the patch. > >> Moved the sysfs entry up one level (to not be in the "holders" > >> directory) and renamed it t cmd_filter (reflects its purpose better > >> than "filter"). > >> > >> ----------------------------- > >> > >> From: Peter Jones <pjones@xxxxxxxxxx> > >> > >> This patch exports the per-gendisk command filter to user space through > >> sysfs, so it can be changed by the system administrator. > >> > >> Signed-off-by: Adel Gadllah <adel.gadllah@xxxxxxxxx> > >> Signed-off-by: Peter Jones <pjones@xxxxxxxxxx> > >> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > > > > I think that the scsi command filter infrastructure should work with > > all the interfaces, bsg, SG_IO, and sg. This doesn't work with sg, > > right? > > > > sg never used any command filtering. (I have converted all users of > the old command filter to the new one). No, sg has own command filtering mechanism, see sg_allow_access(). When we discussed the per-gendisk command filter before, I think that we agreed that we had better to have one command filtering mechanism. > It allowed any scsi command without checking but normally /dev/sg* is > only accessable by root anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
