On Wed, May 21, 2008 at 1:21 AM, Greg KH <greg@xxxxxxxxx> wrote: > On Tue, May 20, 2008 at 03:02:32AM -0700, Andrew Morton wrote: >> On Tue, 20 May 2008 17:55:54 +0800 Dave Young <hidave.darkstar@xxxxxxxxx> wrote: >> >> > Converting class semaphore to mutex cause lockdep warnings due to >> > class_interface_register/unregister will possible call device_add/del >> >> Shouldn't we just fix that? > > Um, no, that's a "feature" that some types of hardware and interfaces > require. > > This is one reason I really don't like this type of conversion, it's > causing lots of problems for no known gain. > > So I would just recommend dropping this patch set, the current "convert > class semaphore to a mutex" patch in the -mm tree is already causing > lockdep warnings, and trying to do something like this isn't really > going to solve the root problem here. At last, I decide to give up. Andrew, I could not do more for this issue now, you can drop the conversion patch if there's no suitable fix from others. Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
