Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael, I was reading over the driver to try and figure out how you
handle allocating source ports for the offloaded TCP connections you
make so that they don't collide with the main network stack.  It looks
like you have:

 > +/**
 > + * bnx2i_alloc_tcp_port - allocates a tcp port from the free list
 > + *
 > + * Assumes this function is called with 'bnx2i_resc_lock' held.
 > + */
 > +static u16 bnx2i_alloc_tcp_port(void)

that has some failure code:

 > +	if (!tcp_port) {
 > +		printk(KERN_ERR "bnx2i: run 'bnx2id' to alloc tcp ports\n");

but I don't know what bnx2id is?

and I didn't see anywhere that bnx2i_get_tcp_port_requirements() is
actually called, and it's not exported?

 > +/**
 > + * bnx2i_get_tcp_port_requirements - returns num tcp ports to alloc/bind
 > + *
 > + * driver returns the number of TCP ports to be allocated/bound by 'bnx2id'
 > + *	daemon. Return value of '0' means driver has everything to support
 > + *	max iscsi connections on enumerated NX2 devices
 > + */
 > +int bnx2i_get_tcp_port_requirements(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux