Re: [PATCH 4/4] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elias Oltmanns wrote:
> > +	char buffer[255];
> >  	int ret;
> >  
> > -	buffer = kmalloc(255, GFP_KERNEL);
> > -	if (!buffer)
> > -		return -ENOMEM;
> > -
> > -	init_cdrom_command(&cgc, buffer, 4, CGC_DATA_READ);
> > +	init_cdrom_command(&cgc, &buffer, 4, CGC_DATA_READ);
> 				 ^
> Careful here.

They're the same in C.

-jim
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux