On Sat, May 17, 2008 at 11:04:31AM +0100, James Bottomley wrote:
> On Fri, 2008-05-16 at 19:06 +0200, Toralf Förster wrote:
> > Hello,
> >
> > the build (.config attached) failed, make ends with :
> > ...
> > UPD include/linux/compile.h
> > CC init/version.o
> > LD init/built-in.o
> > LD vmlinux
> > drivers/built-in.o: In function `sas_request_addr':
> > (.text+0x33bab): undefined reference to `request_firmware'
> > drivers/built-in.o: In function `sas_request_addr':
> > (.text+0x33c3f): undefined reference to `release_firmware'
> > make: *** [vmlinux] Error 1
>
> There's a slight fault in the stub logic. It fails for FW_LOADER=m and
> the user =y.
>
> This should fix it.
An interesting question is whether we actually want to have the stub at
all - the compile errors catched cases where someone forgot to select
FW_LOADER at compile time instead of turning them into possible runtime
problems as will happen after your patch.
Are there any serious use cases where SCSI_SAS_LIBSAS is used in very
space limited environments and without any other drivers that select
FW_LOADER in the kernel?
> James
>
> ---
>
> diff --git a/include/linux/firmware.h b/include/linux/firmware.h
> index 4d10c73..6c7eff2 100644
> --- a/include/linux/firmware.h
> +++ b/include/linux/firmware.h
> @@ -13,7 +13,7 @@ struct firmware {
>
> struct device;
>
> -#if defined(CONFIG_FW_LOADER) || defined(CONFIG_FW_LOADER_MODULE)
> +#if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))
> int request_firmware(const struct firmware **fw, const char *name,
> struct device *device);
> int request_firmware_nowait(
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
