On Wednesday 23 April 2008 05:52:30 Adrian Bunk wrote: > This patch makes the following needlessly global functions static: > - ibft_attr_show_initiator() > - ibft_attr_show_nic() > - ibft_attr_show_target() > > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx> Thanks for catching that. Signed-off-by: Konrad Rzeszutek <ketuzsezr@xxxxxxxxxx> > > --- > > drivers/firmware/iscsi_ibft.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > 421adc9620a633d461059da9a8a94315d8a767ea diff --git > a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index > 8024e3b..8523811 100644 > --- a/drivers/firmware/iscsi_ibft.c > +++ b/drivers/firmware/iscsi_ibft.c > @@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj) > /* > * Routines for parsing the iBFT data to be human readable. > */ > -ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry, > - struct ibft_attribute *attr, > - char *buf) > +static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry, > + struct ibft_attribute *attr, > + char *buf) > { > struct ibft_initiator *initiator = entry->initiator; > void *ibft_loc = entry->header; > @@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject > *entry, return str - buf; > } > > -ssize_t ibft_attr_show_nic(struct ibft_kobject *entry, > - struct ibft_attribute *attr, > - char *buf) > +static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry, > + struct ibft_attribute *attr, > + char *buf) > { > struct ibft_nic *nic = entry->nic; > void *ibft_loc = entry->header; > @@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry, > return str - buf; > }; > > -ssize_t ibft_attr_show_target(struct ibft_kobject *entry, > - struct ibft_attribute *attr, > - char *buf) > +static ssize_t ibft_attr_show_target(struct ibft_kobject *entry, > + struct ibft_attribute *attr, > + char *buf) > { > struct ibft_tgt *tgt = entry->tgt; > void *ibft_loc = entry->header; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html