Re: [RFC] results of endianness review of qla2xxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 19 Apr 2008, Al Viro wrote:

> 	More of that stuff (added by [SCSI] qla2xxx: Add hardware
> trace-logging support):
>                         qla24xx_write_flash_dword(ha, faddr++,
>                             cpu_to_le32(jiffies));
>                         qla24xx_write_flash_dword(ha, faddr++, 0);
>                         qla24xx_write_flash_dword(ha, faddr++, *fdata++);
>                         qla24xx_write_flash_dword(ha, faddr++, *fdata);
> in qla2xxx_hw_event_store().

The data portions of 'fdata[]' are composites of:

	#define QMARK(a, b, c, d) \
	    cpu_to_le32(LSB(a) << 24 | LSB(b) << 16 | LSB(c) << 8 | LSB(d))
	...
	/* Create marker. */
	marker[0] = QMARK('L', ha->fw_major_version,
	    ha->fw_minor_version, ha->fw_subminor_version);
	marker[1] = QMARK(QLA_DRIVER_MAJOR_VER, QLA_DRIVER_MINOR_VER,
	    QLA_DRIVER_PATCH_VER, QLA_DRIVER_BETA_VER);

and:

        /* Store error.  */
        fdata[0] = cpu_to_le32(code << 16 | d1);
        fdata[1] = cpu_to_le32(d2 << 16 | d3);
        rval = qla2xxx_hw_event_store(ha, fdata);

> All other callers pass host-endian last
> argument and function sure as hell looks like it's expecting one...

I'm not entirely clear on what you are driving at here...  The data in
question is written to flash in little-endian format...
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux