On Thu, Apr 17 2008 at 16:04 +0300, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote: > On Thu, 17 Apr 2008 15:25:23 +0300 > Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > >> Add support for variable-length, extended, and vendor specific >> CDBs to scsi-ml. It is now possible for initiators and ULD's >> to issue these types of commands. LLDs need not change much. >> All they need is to raise the .max_cmd_len to the longest command >> they support (see iscsi patch). >> >> - clean-up some code paths that did not expect commands to be >> larger than 16, and change cmd_len members' type to short as >> char is not enough. >> >> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> >> Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> >> --- >> block/scsi_ioctl.c | 5 ++--- >> drivers/scsi/constants.c | 10 +++------- >> drivers/scsi/scsi.c | 15 ++++----------- >> drivers/scsi/scsi_lib.c | 2 +- >> include/scsi/scsi.h | 40 +++++++++++++++++++++++++++++++++------- >> include/scsi/scsi_cmnd.h | 2 +- >> include/scsi/scsi_host.h | 8 +++----- >> 7 files changed, 47 insertions(+), 35 deletions(-) > > looks fine to me though I've not tested it. > -- I agree, we need more testing. I'm doing that right now. I've been running with the old patch for ages and also Pete had a nice heavy load on that code. But this here was not tried as log. Pete if you have a ready made setup maybe you can give it a go. Tomo perhaps you can add these 3 patches to your tests. You need: linux-block for-2.6.26 branch - for block support of large commands scsi-misc - for iscsi's bidi and extended commands these three patches. - scsi varlen support And then the patch for bsg. But over all I have audit the code and it looks good, Tomo was right it was redundant code. Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
