Re: [Patch] zfcp: fix compiler warning caused by poking inside new semaphore (linux-next)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK

On Thu, Apr 17, 2008 at 12:08:03AM +0200, Martin Peschke wrote:
> From: Martin Peschke <mp3@xxxxxxxxxx>
> 
> as seen in linux-next tree:
> 
> drivers/s390/scsi/zfcp_dbf.c: In function ‘zfcp_rec_dbf_event_thread’:
> drivers/s390/scsi/zfcp_dbf.c:697: warning: passing argument 1 of ‘atomic_read’
>  from incompatible pointer type
> 
> Caused by recent git commit 348447e85749120ad600a5c8e23b6bb7058b931d
> 
> We are not supposed to poke inside semaphore.
> 
> Signed-off-by: Martin Peschke <mp3@xxxxxxxxxx>
> ---
>  drivers/s390/scsi/zfcp_dbf.c |    2 --
>  drivers/s390/scsi/zfcp_dbf.h |    1 -
>  2 files changed, 3 deletions(-)
> 
> --- a/drivers/s390/scsi/zfcp_dbf.c
> +++ b/drivers/s390/scsi/zfcp_dbf.c
> @@ -623,7 +623,6 @@ static int zfcp_rec_dbf_view_format(debu
>  	zfcp_dbf_out(&p, "id", "%d", r->id2);
>  	switch (r->id) {
>  	case ZFCP_REC_DBF_ID_THREAD:
> -		zfcp_dbf_out(&p, "sema", "%d", r->u.thread.sema);
>  		zfcp_dbf_out(&p, "total", "%d", r->u.thread.total);
>  		zfcp_dbf_out(&p, "ready", "%d", r->u.thread.ready);
>  		zfcp_dbf_out(&p, "running", "%d", r->u.thread.running);
> @@ -694,7 +693,6 @@ void zfcp_rec_dbf_event_thread(u8 id2, s
>  	memset(r, 0, sizeof(*r));
>  	r->id = ZFCP_REC_DBF_ID_THREAD;
>  	r->id2 = id2;
> -	r->u.thread.sema = atomic_read(&adapter->erp_ready_sem.count);
>  	r->u.thread.total = total;
>  	r->u.thread.ready = ready;
>  	r->u.thread.running = running;
> --- a/drivers/s390/scsi/zfcp_dbf.h
> +++ b/drivers/s390/scsi/zfcp_dbf.h
> @@ -35,7 +35,6 @@ struct zfcp_dbf_dump {
>  } __attribute__ ((packed));
> 
>  struct zfcp_rec_dbf_record_thread {
> -	u32 sema;
>  	u32 total;
>  	u32 ready;
>  	u32 running;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux