Re: [PATCH 2/3] debloat aic7xxx and aic79xx drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,

On Tuesday 08 April 2008 16:08, Denys Vlasenko wrote:
> > > #if 0 / #endif block ends up containing definitions of 290 functions/macros,
> > > none of which is EVER used. I used this script (below) and verified that
> > > they are never mentioned anywhere outside of *_shipped files.
> > > I also did test builds with and without debug enabled and they build
> > > with no problems. No undefined references!
> > > 
> > Well, still not quite. The point here is that all of the functions in the
> > *_shipped files are in fact auto-generated by aicasm, based on the definitions
> > in aic79xx.seq and aic79xx.reg. So the *_reg_print.c files contains
> > functions for all _defined_ registers, not the actually used ones.
> > What we have to do here is to modify aicasm to not print out the
> > unused definitions, and copy those (autogenerated) files over to
> > the *_shipped files to have them synced properly.
> > Hand-patching the *_shipped files is not a good idea.
> 
> I do understand this, and I do understnad then _shipped files
> are generated. But I failed to find out HOW they are generated.
> I don't want to _only_ patch aicasm/* files and skip checking
> that my changes work (or at least compile).
> 
> Please let me know how to regenerate these _shipped files,
> and I will fix it "correctly" by modifying aicasm/* files.

I didn't get any reply. Perhaps you were busy with more important stuff.

Ping! :)
--
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux