On Thu, Apr 10, 2008 at 08:44:26PM -0700, Jason Chu wrote: > No need more spaces for sas_phys and sas_port. > > Signed-off-by:: Ying Chu <jasonchu@xxxxxxxxxxx> > --- > driver/scsi/aic94xx/aic94xx_init.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/aic94xx/aic94xx_init.c > b/drivers/scsi/aic94xx/aic94xx_init.c > index 88d1e73..0400bd2 100644 > --- a/drivers/scsi/aic94xx/aic94xx_init.c > +++ b/drivers/scsi/aic94xx/aic94xx_init.c > @@ -689,9 +689,9 @@ static int asd_register_sas_ha(struct as > { > int i; > struct asd_sas_phy **sas_phys = > - kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_phy), > GFP_KERNEL); > + kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_phy *), > GFP_KERNEL); Given that sas_phys is a pointer to pointers, I don't think that taking the pointer out of the sizeof is the proper thing to do. --D -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html