Re: [PATCH 1/2] block: move the padding adjustment to blk_rq_map_sg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 08 Apr 2008 10:49:22 +0900
Tejun Heo <htejun@xxxxxxxxx> wrote:

> Hello,
> 
> FUJITA Tomonori wrote:
> >>> The current code does padding only for requests that we call
> >>> __blk_rq_map_user (bio_copy_user) for. You meant that if we create a
> >>> new flag like REQ_NEED_PADDING and set it in blk_rq_map_user,
> >>> blk_rq_map_sg can do padding only when it was set.
> >> Yeap, that's what I meant.
> > 
> > Thanks, I see. Then, I have one question: blk_rq_map_user_iov doesn't
> > padding, thus libata still needs to adjust scatter list, right?
> 
> Yes but it doesn't, so blk_rq_map_user_iov() path is essentially broken 
> regarding padding at the moment.  :-(

I see. So we need to use bounce buffers for blk_rq_map_user_iov like
bio_copy_user does for blk_rq_map_user?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux