On Thu, Apr 03 2008, Boaz Harrosh wrote:
> static void req_bio_endio(struct request *rq, struct bio *bio,
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 6f79d40..2f87c9d 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -213,8 +213,15 @@ struct request {
> /*
> * when request is used as a packet command carrier
> */
> - unsigned int cmd_len;
> - unsigned char cmd[BLK_MAX_CDB];
> + unsigned short cmd_len;
> + unsigned short ext_cdb_len; /* length of ext_cdb buffer */
> + union {
> + unsigned char cmd[BLK_MAX_CDB];
> + unsigned char *ext_cdb;/* an optional extended cdb.
> + * points to a user buffer that must
> + * be valid until end of request
> + */
> + };
Why not just something ala
unsigned short cmd_len;
unsigned char __cmd[BLK_MAX_CDB];
unsigned char *cmd;
and then have rq_init() do
rq->cmd = rq->__cmd;
and just have a function for setting up a larger ->cmd and adjusting
->cmd_len in the process?
Then rq_set_cdb() would be
static inline void rq_set_cdb(struct request *rq, u8 *cdb, short cdb_len)
{
rq->cmd = cdb;
rq->cmd_len = cdb_len;
}
and rq_get_cdb() plus rq_get_cdb_len() could just go away.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
