On Thu, 2008-03-06 at 10:04 +0800, nickcheng wrote: > James, > You are such a great teacher. Heh, you know how to smooth talk > I learned it. > So what about my last submitted patch? > Would it be turned down or go on? I'm fine with either fix. For either we need a better changelog. Something like: The Type B Adapter teardown does iounmap on pointers subtracted by a constant offset. Since the offset is in bytes, we need the pointers to be of type void * not uint32_t * so the subtraction is done in the correct units and we iounmap the correct area. Signed-off-by: ... James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html