On Thu, Mar 06, 2008 at 02:04:59PM -0700, Matthew Wilcox wrote: > On Thu, Mar 06, 2008 at 09:51:21PM +0100, Andi Kleen wrote: > > That patch is a little more complicated than the others. advansys > > was the only ISA driver who actually passed ->cmnd to the firmware. > > Why did you ignore me the first time when I told you that you'd made a > mistake? Can you be more specific what you complained about? As I remember you had a quite vague high level complaint last time ("very ugly patch") but you didn't go into details as what exactly you considered ugly. I assumed you meant not using the DMA API but raw get_free_pages with "ugly", and I fixed that. If you have any other issues with the patch please describe them clearly. Assume I'm like a 4 year old regarding SCSI arcana. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html