On Wed, 05 Mar 2008 09:44:01 +0900 Tejun Heo <htejun@xxxxxxxxx> wrote: > >> Things going the other way is fine with me but I at least want to hear a > >> valid rationale. Till now all I got is "because that's the true size" > >> which doesn't really make much sense to me. > > > > Most of users of request structure care about only the real data > > length, don't care about padding and drain length. Why do they bother > > to use a helper function to get the real data length? > > I think this is where the difference comes from. To me it seems > internal usage seems more wide-spread and more delicate and not too many > care about the true size and when they do only in well defined places. > Maybe it comes from the difference between your most and my most. I don't think that they only in well defined places. If you see scsi mid-layer (and LLDs), you can find several places that use rq->data_len as the true data length. Breaking rq->data_len == the true data length theoretically wrong. Even if it affects only libata now, it will hurt us, I think. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
