On Tue, 26 Feb 2008, FUJITA Tomonori wrote: > On Mon, 25 Feb 2008 14:24:31 +0100 (CET) > Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote: > > > Subject: [PATCH] ps3rom: Simplify fill_from_dev_buffer() > > > > As we no longer need to calculate the data length of the whole scatterlist, > > we can abort the loop earlier and coalesce req_len and act_len into one > > variable, making fill_from_dev_buffer() more similar to fetch_to_dev_buffer(). > > I'll add new APIs to copy data between a sg list and a buffer soon > after cleaning up (and fixing) some drivers on this area. I plan to > remove fill_from_dev_buffer and fetch_to_dev_buffer in ps3rom. As you > know, they are same functions that scsi_debug uses. There are other > drivers that need similar functions. I expect my ps3rom patch to be > applied to the scsi-fixes tree so I didn't change much as you did in > this patch. IC, thanks! With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619