On Thu, 7 Feb 2008 12:14:56 +0100 "Harald Arnesen" <skogtun.linux@xxxxxxxxx> wrote: > On 2/7/08, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > (cc's restored, and expanded a bit) > > Ah, sorry, not used to gmail's web interface. Clicked the wrong button. > > > > Seems to be the advansys driver, so I tried to remove it - and indeed, > > > the kernel now boots. So I guess it's either that driver or my ancient > > > Nikon Coolscan II that is the only thing attached to the board. > > > > Thanks. I uploaded the oops picture to > > http://userweb.kernel.org/~akpm/oops.jpg > > > > > Cc to the Matthew Wilcox added. > > > > mm... looks like all Matthew's changes were in 2.6.23. And 2.6.23 worked > > OK, yes? > > Both 2.6.23 and 2.6.24 are ok. > > > The only recent changes to drivers/scsi/advansys.c are > > > > commit b80ca4f7ee36c26d300c5a8f429e73372d153379 > > Author: FUJITA Tomonori <tomof@xxxxxxx> > > Date: Sun Jan 13 15:46:13 2008 +0900 > > > > [SCSI] replace sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE > > > > This replaces sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in > > several LLDs. It's a preparation for the future changes to remove > > sense_buffer array in scsi_cmnd structure. > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > > > :100644 100644 9dd3952... 492702b... M drivers/scsi/advansys.c > > > > commit 747d016e7e25e216b31022fe2b012508d99fb682 > > Author: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Date: Mon Jan 14 00:55:18 2008 -0800 > > > > advansys: fix section mismatch warning > > > > Fix section mismatch warning: > > > > WARNING: vmlinux.o(.exit.text+0x152a): Section mismatch: reference to .init. > > > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Cc: Matthew Wilcox <willy@xxxxxxxxxx> > > Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> > > > > which seem fairly benign. > > > > > > gcc inlining is going to make it rather a lot of work to find out which > > statement has actually oopsed there. > -- Can you try this? Thanks, diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 374ed02..f5dde12 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -566,7 +566,7 @@ typedef struct asc_dvc_var { ASC_SCSI_BIT_ID_TYPE unit_not_ready; ASC_SCSI_BIT_ID_TYPE queue_full_or_busy; ASC_SCSI_BIT_ID_TYPE start_motor; - uchar overrun_buf[ASC_OVERRUN_BSIZE] __aligned(8); + uchar *overrun_buf; dma_addr_t overrun_dma; uchar scsi_reset_wait; uchar chip_no; @@ -13833,6 +13833,12 @@ static int __devinit advansys_board_found(struct Scsi_Host *shost, */ if (ASC_NARROW_BOARD(boardp)) { ASC_DBG(2, "AscInitAsc1000Driver()\n"); + + asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL); + if (!asc_dvc_varp->overrun_buf) { + ret = -ENOMEM; + goto err_free_wide_mem; + } warn_code = AscInitAsc1000Driver(asc_dvc_varp); if (warn_code || asc_dvc_varp->err_code) { @@ -13840,8 +13846,10 @@ static int __devinit advansys_board_found(struct Scsi_Host *shost, "warn 0x%x, error 0x%x\n", asc_dvc_varp->init_state, warn_code, asc_dvc_varp->err_code); - if (asc_dvc_varp->err_code) + if (asc_dvc_varp->err_code) { ret = -ENODEV; + kfree(asc_dvc_varp->overrun_buf); + } } } else { if (advansys_wide_init_chip(shost)) @@ -13891,9 +13899,11 @@ static int advansys_release(struct Scsi_Host *shost) free_dma(shost->dma_channel); } if (ASC_NARROW_BOARD(board)) { + ASC_DVC_VAR *asc_dvc_varp = &board->dvc_var.asc_dvc_var; dma_unmap_single(board->dev, board->dvc_var.asc_dvc_var.overrun_dma, ASC_OVERRUN_BSIZE, DMA_FROM_DEVICE); + kfree(asc_dvc_varp->overrun_buf); } else { iounmap(board->ioremap_addr); advansys_wide_free_mem(board); - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
