RE: [PATCH 03/12] qla4xxx: have qla4xxx use iscsi class session state check ready

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Christie wrote :
> This has qla4xxx use the iscsi class's check ready function
> in the queue command function, so all iscsi drivers return the
> same error value for common problems.
> 
> Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c 
> b/drivers/scsi/qla4xxx/ql4_os.c
> index a87fb9f..437d169 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -398,9 +398,21 @@ static int qla4xxx_queuecommand(struct 
> scsi_cmnd *cmd,
>  {
>  	struct scsi_qla_host *ha = to_qla_host(cmd->device->host);
>  	struct ddb_entry *ddb_entry = cmd->device->hostdata;
> +	struct iscsi_cls_session *sess = ddb_entry->sess;
>  	struct srb *srb;
>  	int rval;
>  
> +	if (!sess) {
> +		cmd->result = DID_IMM_RETRY << 16;
> +		goto qc_fail_command;
> +	}
> +
> +	rval = iscsi_session_chkready(sess);
> +	if (rval) {
> +		cmd->result = rval;
> +		goto qc_fail_command;
> +	}
> +
>  	if (atomic_read(&ddb_entry->state) != DDB_STATE_ONLINE) {
>  		if (atomic_read(&ddb_entry->state) == DDB_STATE_DEAD) {
>  			cmd->result = DID_NO_CONNECT << 16;
> -- 
> 1.5.2.1
Acked by David Somayajulu <david.somayajulu@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux