Re: [PATCH] [RFC] sd: make error handling more robust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



--- On Thu, 1/31/08, Luben Tuikov <ltuikov@xxxxxxxxx> wrote:
> Negate original:
>     if (driver_byte(result) == DRIVER_SENSE ||
>         (sense_valid && sense_defered))
>             Inspect sense.
> 
> Negate your proposed change "&&" ->
> "||":
>     if (driver_byte(result) == DRIVER_SENSE &&
>          (sense_valid || sense_deferred))
>                 Inspect sense.

Should read:

Negate original:
     if (driver_byte(result) == DRIVER_SENSE ||
         (sense_valid && !sense_deferred))
             Inspect sense.

Negate your proposed change "&&" -> "||":
     if (driver_byte(result) == DRIVER_SENSE &&
         (sense_valid || !sense_deferred))
             Inspect sense.

  Luben

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux