On Thu, Jan 31 2008 at 18:45 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > >>>> Please check the below patch. >>>> >>>> one thing that I can see is that the isd200 does an INQUARY transfer >>>> of sizeof(struct inquiry_data) which is 96 bytes, when scsi_scan.c >>>> sends an INQUARY with 36 bytes buffer. So we have an underflow in >>>> usb_stor_access_xfer_buf(). > > Maybe the isd200 routine should be changed also, so that it doesn't try > to store too much data in the buffer. > >> I will send a proper patch to scsi maintainer. Alan is it OK to send this >> patch threw James's scsi-misc? > > You should send patches to Matt Dharm, since he is the usb-storage > maintainer. > > Alan Stern > > - Right, Please see patch posted as reply to the original email. I have also fixed isd200 to return what was asked. The fix to protocol.c is also different and more general now. Will send to Matthew Dharm. Matthew - is it OK to send this threw James, please ACK. Mark - this fix is different we do need testing. Thanks to all Boaz - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
