Re: [UPDATED PATCH] SGIWD93: use cached memory access to make driver work on IP28

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 25, 2008 at 10:44:40AM -0600, James Bottomley wrote:
> > +	void *cpu;
> > +	void *dev;
> 
> This should be struct device *dev; shouldn't it (that seems to be how
> it's always used)?

of course, no need for the void *.

> And that should be dma_free_noncoherent(&pdev->dev, ...) shouldn't it?

yes it should.

I'm sending an updated patch in a couple of seconds. Thanks for
the review.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux