Re: on patch "[SCSI] relax scsi dma alignment"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2008-01-26 at 19:49 +0100, Stefan Richter wrote:
> On commit 465ff3185e0cb76d46137335a4d21d0d9d3ac8a2:
> > This patch relaxes the default SCSI DMA alignment from 512 bytes to 4
> > bytes.  I remember from previous discussions that usb and firewire have
> > sector size alignment requirements, so I upped their alignments in the
> > respective slave allocs.
> [...]
> >  drivers/ata/libata-scsi.c      |    5 ++++-
> >  drivers/firewire/fw-sbp2.c     |    6 ++++++
> >  drivers/ieee1394/sbp2.c        |    6 ++++++
> >  drivers/scsi/scsi_lib.c        |    8 ++++++++
> >  drivers/usb/storage/scsiglue.c |   20 ++++++++++----------
> >  5 files changed, 34 insertions(+), 11 deletions(-)
> 
> No, FireWire only requires 4 bytes alignment.
> 
> I will channel a reversion of the firewire and ieee1394 hunks through
> linux1394-2.6.git for 2.6.26.

Don't revert, just put the numbers down to 4 (just in case someone
decides to lower the default SCSI alignment down from four ...).

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux