On Fri, 25 Jan 2008 20:05:55 -0600 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, 2008-01-26 at 09:57 +0900, FUJITA Tomonori wrote: > > This is against the scsi-bidi tree. > > > > We need to use the cmd_type of a leading request for scsi_init_sgtable > > to set up scsi_data_buffer:length of a bidi request properly. > > > > An alternative approach is setting the cmd_type of a leading request > > and its bidi request (*1). But the block layer and scsi-ml don't > > expect that the leading request and its sub-requests have the > > different command types. > > > > Note that scsi_debug's XDWRITEREAD_10 support is fine without this > > patch since req->nr_sectors works for it but req->nr_sectors doesn't > > work for everyone. > > > > (*1) > > > > http://www.mail-archive.com/linux-scsi@xxxxxxxxxxxxxxx/msg12669.html > > > > = > > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > > Subject: [PATCH] use the cmd_type of a leading request for scsi_init_sgtable > > > > We need to use the cmd_type of a leading request for scsi_init_sgtable > > to set up scsi_data_buffer:length of its bidi request properly. > > This seems to be a very convoluted work around for the fact that we > forgot to set the cmd_type on the subordinate request. > > Wouldn't this be a better fix? I'm fine with this. I have no big preference in this issue. Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> I just thought that the approach (the block layer and scsi-ml look at only the type of a leading request) show better how the block layer and scsi-ml see a leading request and its subordinate requests (all the requests need to have the same command type). > James > > --- > > diff --git a/block/bsg.c b/block/bsg.c > index 69b0a9d..8917c51 100644 > --- a/block/bsg.c > +++ b/block/bsg.c > @@ -279,6 +279,7 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr) > goto out; > } > rq->next_rq = next_rq; > + next_rq->cmd_type = rq->cmd_type; > > dxferp = (void*)(unsigned long)hdr->din_xferp; > ret = blk_rq_map_user(q, next_rq, dxferp, hdr->din_xfer_len); > > > - > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
