On Wed, 2008-01-23 at 10:12 -0800, Greg KH wrote: > On Sun, Jan 20, 2008 at 04:45:36PM -0500, Alan Stern wrote: > > On Sun, 20 Jan 2008, Greg KH wrote: > > > > > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > > > Hi all, > > > > > > > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > > > > needed to makes the cardreader on various HP multifunction printers work. > > > > > > > > Since the performance impact is negible we set this flag for all USB disks > > > > to avoid an unusual_devs.h nightmare. > > > > > > Oh great, now my "working just fine" USB devices, which happen to have > > > data in the last sector, suddenly stop working. > > > > > > That's not acceptable :( > > > > These patches really should not impact existing devices. If they do > > then something is definitely wrong. > > > > Can you provide detailed logging information showing your problem? For > > example, a usbmon trace would be good. Better yet, a usbmon trace > > without the patches and a usbmon trace with the patches, for > > comparison. > > I don't have a device with such a problem, I just am worried that we are > now suddenly keeping access from the last sector for devices that > currently did work just fine. > > If you all guarantee that this will not happen, hey, I'm happy, and I'll > gladly point all bug reports on to you all :) Hey, you can trust me ... I'm a doctor ... Would you like me to add your 'Responsibility-disclamed-by:' to the patch ...? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
