On Tue, Jan 22, 2008 at 09:27:09PM -0800, Phil Dibowitz wrote: ... > Patch looks fine to me. Let me get my tree in order (sorry, been really > swamped lately so I haven't updated in a while), make sure this diff's > nicely against the latest rc's, It's not. It's against 2.6.23. But I expect it to apply with fuzz at the worst case. > and I'll pass it on up. .24 is already > (essentially) done, so I'll get it to Greg in the next day or so and it > should make it into .25. thanks! > > Sorry for the delay, and thanks Alan for pinging me on this. > > As for Grant - more information on "Protocol" vs "Subclass" can be found on > my unusual_devs page here: > > http://www.phildev.net/linux/usb-unusualdevs-notes.html In general, a very helpful document! Thanks! "useProtocol - These are listed in protocols.h with explinations. One example: * US_SC_DEVICE - use whatever the device claims * see drivers/usb/storage/protocol.h for a full list and comments " Some issues/comments: o I don't see any sort of list in protocol.h. And the comments in protocol.h don't discuss useProtocol or which protocols. Maybe "the list" moved to include/linux/usb_usual.h? o US_SC_* and US_PR_* constants both seem like good candidates for enum (to make sure the right "type" get used with the right field.) cheers, grant - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
