Re: [PATCH 1/8] firewire: ieee1394: Move away from SG_ALL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Boaz Harrosh wrote:
>   SG_ALL wants to be ~0 meaning "any future size".
>   Below group of drivers preallocate a scatter list
>   buffer of max_size, so set that size to be 255 (Like before).
> 
>   A better schema can be advised with a more dynamic allocation.
>   Perhaps from a kmem_cache.
> 
>   List of drivers/files:
> 	drivers/firewire/fw-sbp2.c
> 	drivers/ieee1394/sbp2.[ch]
> 
> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>

Acked-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>

> ---
>  drivers/firewire/fw-sbp2.c |    6 ++++--
>  drivers/ieee1394/sbp2.c    |    2 +-
>  drivers/ieee1394/sbp2.h    |    4 +++-
>  3 files changed, 8 insertions(+), 4 deletions(-)

Since I wasn't Cc'd, I suppose you don't want me to take it upstream via
linux1394-2.6.git?

My guess is that there won't be conflicts of this with linux1394-2.6.git
anytime soon, so taking it into any other tree should be fine.
-- 
Stefan Richter
-=====-==--- ---= =---=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux