RE: [PATCH 1/2] don't zero out sense_buffer in queuecommand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK on ips bits.

Sincerely -- Mark Salyzyn
. . .
> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
> index e54d30c..b1b2295 100644
> --- a/drivers/scsi/ips.c
> +++ b/drivers/scsi/ips.c
> @@ -2736,8 +2736,6 @@ ips_next(ips_ha_t * ha, int intr)
>                 SC->result = DID_OK;
>                 SC->host_scribble = NULL;
>
> -               memset(SC->sense_buffer, 0, sizeof
> (SC->sense_buffer));
> -
>                 scb->target_id = SC->device->id;
>                 scb->lun = SC->device->lun;
>                 scb->bus = SC->device->channel;
> @@ -3821,7 +3819,6 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
>                         /* attempted, a Check Condition
> occurred, and Sense   */
>                         /* Data indicating an Invalid CDB
> OpCode is returned. */
>                         sp = (char *) scb->scsi_cmd->sense_buffer;
> -                       memset(sp, 0, sizeof
> (scb->scsi_cmd->sense_buffer));
>
>                         sp[0] = 0x70;   /* Error Code               */
>                         sp[2] = ILLEGAL_REQUEST;        /*
> Sense Key 5 Illegal Req. */
. . .
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux