On Sat, Jan 05, 2008 at 10:18:27AM -0600, James Bottomley wrote: > This conversion makes full use of the is_visible() callback on attribute > groups. Now, each device appears only with its capability flags in the > transport class directory. Previously each device appeared with the > capability of the host, so this is a functionality improvement. > Converting to attribute groups allows us to sweep away most of the home > grown #defines that were effectively doing the same thing. > > James > > --- > > This depends on: > > [PATCH] sysfs: add filter function to groups > [PATCH] fix the sysfs_add_file_to_group interfaces > [PATCH] attribute_container: update to use the group interface > [PATCH] add missing transport configure points for target and host > > Greg and Kay, there's a nasty point in the code where I'd like to use > the -EEXIST return of sysfs_add_file_to_group() to indicate the file is > already there, however, this also dumps a stack trace and would frighten > users ... can we get rid of the printk and the WARN_ON(1)? I really don't want to, as it has caught a lot of problems in the past. What do you want to do that needs this error to happen "properly"? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
