On Thu, Jan 10, 2008 at 05:48:43PM +0800, Dave Young wrote: > The patches are done on my side, please help to check. Along with all of the other comments from people, I have a few. > This is the first one of the series about driver core changes. > If this one is accepted and there's no other problem I will post the others for maintainer's review (they need your comment and help because I don't know well about the specific driver logic). > > Thanks a lot in advance. > --- > > 1. convert class semaphore to mutex. > 2. add class iterater functions to encapsulate the detail of class devices/children list iterating : > class_for_each_device > class_find_device > class_for_each_child > class_find_child No, please create 1 patch per type-of-change. So in this case you would have a series of patches: 1) add the class iterator functions 2-n) convert the existing places in the kernel using the class->semaphore to use the new iterator functions n+1) convert class semaphore to mutex, which should only touch the driver core That way everything builds along the way, and it's easy to understand and review. Oh, and please start a new thread when you create a new patch like this so it doesn't get burried in people's inboxes... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
