James Bottomley wrote:
On Sun, 2008-01-06 at 04:02 +0100, Richard Knutsson wrote:
Hi all
drivers/scsi/scsi_typedefs.h is about ready to be removed, only the
'struct scsi_cmnd' typedef Scsi_Cmnd is left.
This set converts all the Scsi_Cmnd's, except in:
Changelogs
Documentation/scsi/scsi_mid_low_api.txt
So if all these gets merged, in one form or the other, we can:
un'include scsi_typedefs.h from drivers/scsi/scsi.h
fix the text in Documentation/scsi/scsi_mid_low_api.txt
(finally) remove the file in question
Left the "over 80 characters wide"-warnings alone, until requested otherwise.
Am not subscribed on linux-scsi@xxxxxxxxxxxxxxx, so if replying, please Cc: me.
Actually, a lot of this is superfluous ... the drivers are already
removed in the scsi-misc-2.6 tree.
When are they be expected to be removed in the mainstream?
The ideal is to remove this line:
#include "scsi.h"
Because that file (and scsi_typedefs.h) should be expendable by the end
of all of this (their whole purpose was so we didn't have to convert all
the typedefs), and then check the thing still compiles---you probably
have to add in some of the standard #include <scsi/scsi_..> files.
Sounds reasonable.
Please also don't bother with downcasing Scsi_Cmnd capitalisation in
the comments, that's a quirk I'm happy to leave, since it's unambiguous
in the doc book.
Ok, not like it is a real bother & can't imagine this would be a
possible source for collision with other patches, but I don't mind
either way.
Thanks
Richard Knutsson
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
