On Sun, 2008-01-06 at 20:03 +0100, Richard Knutsson wrote: > Convert glue-include "scsi.h" to <scsi.h> (and friends). > > (binary sizes) > allyesconfig: before: 260132 > after: 260048 > > allmodconfig: before: 261740 > after: 261656 > > Signed-off-by: Richard Knutsson <ricknu-0@xxxxxxxxxxxxxx> > --- > Do not have the hardware, but since it compiles I hope it is alright. > > > diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c > index 66c6520..9f1e2c5 100644 > --- a/drivers/scsi/megaraid.c > +++ b/drivers/scsi/megaraid.c > @@ -48,8 +48,9 @@ > #include <linux/dma-mapping.h> > #include <scsi/scsicam.h> > > -#include "scsi.h" > +#include <scsi/scsi_cmnd.h> > #include <scsi/scsi_host.h> > +#include <scsi.h> I'm afraid this is pretty much wrong. The scsi.h being referred to here is the local scsi.h in the build directory, so it should be included as a string. For #include, "..." means begin the search in the local directory (what is wanted here) and <...> means begin the search starting with the predefined include paths. The rest of the patch looks like a spurious (unrelated and undescribed) downcasing of TRUE and FALSE. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html