ACK on aacraid/ips/dpt_i2o bits. Inspected others, this patch IS inert.
NitMeBeingStupidAndAddingARiderToTheBill: I know it was a grep/replace.
If you need to respin because of Boaz and do not mind, do not hesitate
to optimize (?) and instead do:
diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 70f48a1..c6380c0 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2298,7 +2298,6 @@ static s32 adpt_i2o_to_scsi(void __iomem *reply,
struct scsi_cmnd* cmd)
// copy over the request sense data if it was a check
// condition status
- if(dev_status == 0x02 /*CHECK_CONDITION*/) {
- u32 len = sizeof(cmd->sense_buffer);
- len = (len > 40) ? 40 : len;
+ if (dev_status == 0x02 /*CHECK_CONDITION*/) {
+ u32 len = (SCSI_SENSE_BUFFERSIZE > 40) ? 40 :
SCSI_SENSE_BUFFERSIZE;
// Copy over the sense data
memcpy_fromio(cmd->sense_buffer, (reply+28) ,
len);
Sincerely -- Mark Salyzyn
> -----Original Message-----
> From: linux-scsi-owner@xxxxxxxxxxxxxxx
> [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of FUJITA Tomonori
> Sent: Wednesday, January 02, 2008 11:57 PM
> To: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx; benh@xxxxxxxxxxxxxxxxxxx;
> fujita.tomonori@xxxxxxxxxxxxx
> Subject: [PATCH 1/2] replace sizeof sense_buffer with
> SCSI_SENSE_BUFFERSIZE
>
> To remove sense_buffer array in scsi_cmnd structure, this replaces
> sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> ---
. . .
> drivers/scsi/aacraid/aachba.c | 12 ++++++------
. . .
> drivers/scsi/dpt_i2o.c | 2 +-
. . .
> drivers/scsi/ips.c | 10 ++++------
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
