On Thu, Dec 20 2007, Rusty Russell wrote: > On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote: > > On Thu, 20 Dec 2007 16:45:18 +1100 > > > > Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > > > OK, some fixes since last time, as I wade through more SCSI drivers. > > > Some drivers use "use_sg" as a flag to know whether the request_buffer is > > > a scatterlist: I don't need the counter, but I still need the flag, so I > > > fixed that in a more intuitive way (an explicit ->sg pointer in the cmd). > > > > use_sg and the request_buffer will be removed shortly. > > > > http://marc.info/?l=linux-scsi&m=119754650614813&w=2 > > Thanks! Is there a git tree somewhere with these changes? > > > I think that we tried the similar idea before, scsi_sgtable, but we > > seem to settle in the current simple approach. > > Yes, a scsi-specific solution is a bad idea: other people use sg. > Manipulating the magic chains is horrible; it looks simple to the places > which simply want to iterate through it, but it's awful for code which wants > to create them. The current code looks like that to minimize impact on 2.6.24, see this branch: http://git.kernel.dk/?p=linux-2.6-block.git;a=shortlog;h=sg for how it folds into lib/sg.c and the magic disappears from SCSI. Rusty, nobody claimed the sg code in 2.6.24 is perfect. I like to get things incrementally there. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
