On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert <galibert@xxxxxxxxx> wrote:
> On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
>> Below fixes a deadly typo. Might as well be included in 2.6.24
>
> You're sure ? scsi_for_each_sg includes a (sg)++ already...
>
>
>> scsi_for_each_sg(cmnd, sglist, cblk->sglen, i) {
>> sg->data = cpu_to_le32((u32)sg_dma_address(sglist));
>> total_len += sg->len = cpu_to_le32((u32)sg_dma_len(sglist));
>> + ++sg;
>> }
>
> OG.
> --
Don't mix up between the here sg that points to a driver specific struct sg_entry
and the here sglist which points to struct scatterlist, and is named sg inside
the scsi_for_each_sg() macro. Please inspect the full code, the patch does not
show the complete information. I admit it's confusing.
Boaz
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
