AFAIR, this was the nsp32_msg() James wanted to keep, and the patch
should therefore be dropped.
cu
Adrian
On Wed, Nov 21, 2007 at 03:12:15PM -0800, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Adrian Bunk <bunk@xxxxxxxxx>
>
> The Coverity checker noted that we'll anyway Oops later when we ran into
> this condition - and the error check didn't prevent that.
>
> Considering that the error condition shouldn't be possible, and we are
> not able to handle it easily, this patch simply removes the pointless
> error check.
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> Cc: <yokota@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/scsi/nsp32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff -puN drivers/scsi/nsp32.c~nsp32_restart_autoscsi-remove-error-check drivers/scsi/nsp32.c
> --- a/drivers/scsi/nsp32.c~nsp32_restart_autoscsi-remove-error-check
> +++ a/drivers/scsi/nsp32.c
> @@ -1906,10 +1906,6 @@ static void nsp32_restart_autoscsi(struc
>
> nsp32_dbg(NSP32_DEBUG_RESTART, "enter");
>
> - if (data->cur_target == NULL || data->cur_lunt == NULL) {
> - nsp32_msg(KERN_ERR, "Target or Lun is invalid");
> - }
> -
> /*
> * set SYNC_REG
> * Don't set BM_START_ADR before setting this register.
> _
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
