Jonathan McDowell sez: > On Tue, Nov 20, 2007 at 11:35:26AM -0500, James Smart wrote: > > The hearburn I have with these patches is that you are changing > > driver-specific attributes, not common ones as > > enforced/requested by a > > subsystem. As such, you are breaking a management interface for > > existing tools/scripts. > Yes, that's true. Though at present we have the heartburn that anyone > wanting to write a script to pull out firmware revisions has to know > exactly where every driver stores this information. The aacraid cards, which uses hba_monitor_version, hba_kernel_version and hba_bios_version for each piece does not fit into the single 'firmware revision' common ideal and were noticeably missing from this patch set. Fortunately (?), Adaptec has not bought into using sysfs for their management applications to pull these pieces and continues to pick them up directly by issuing ioctl pass-through calls to the card's firmware, so we have some leeway to change them to mold to a developing standard. The fact that sysfs is a developing standard will confirm the management application folks reasoning for shying away from sysfs ;-/ Sincerely -- Mark Salyzyn - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
