ACK. Inspected only. Looks ok. Sincerely -- Mark Salyzyn > -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx > [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Jeff Garzik > Sent: Wednesday, October 24, 2007 7:49 PM > To: LKML; linux-scsi@xxxxxxxxxxxxxxx > Cc: akpm@xxxxxxxxxxxxxxxxxxxx > Subject: [PATCH 3/4] [SCSI] ips: PCI API cleanups > > * pass Scsi_Host to ips_remove_device() via pci_set_drvdata(), > allowing us to eliminate the ips_ha[] search loop and call > ips_release() directly. > > * call pci_{request,release}_regions() and eliminate individual > request/release_[mem_]region() calls > > * call pci_disable_device(), paired with pci_enable_device() > > * s/0/NULL/ in a few places > > * check ioremap() return value > > Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx> > --- > drivers/scsi/ips.c | 72 > ++++++++++++++++++++++----------------------------- > 1 files changed, 31 insertions(+), 41 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
