Re: [PATCH] scsi/sym53c8xx: Fix a warning in sym_eh_handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2007 at 11:37:18AM +0200, Boaz Harrosh wrote:
> On Wed, Oct 24 2007 at 11:59 +0200, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> > -		struct completion *io_reset;
> > -		int finished_reset = 0;
> > +		struct completion *io_reset = NULL;
> > +		int finished_reset;
[...]
> > -		if (!finished_reset)
> > +		if (io_reset) {

> I think you should use uninitialized_var and not brute = NULL;

Look at the patch more carefully ... uninitialized_var would be
inappropriate.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux