Re: Subject: [PATCH] tgt: use KMEM_CACHE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Oct 2007 01:21:29 +0900
FUJITA Tomonori <tomof@xxxxxxx> wrote:

> Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> ---
>  drivers/scsi/scsi_tgt_lib.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c
> index deea3cd..7abef1a 100644
> --- a/drivers/scsi/scsi_tgt_lib.c
> +++ b/drivers/scsi/scsi_tgt_lib.c
> @@ -641,9 +641,7 @@ static int __init scsi_tgt_init(void)
>  {
>  	int err;
>  
> -	scsi_tgt_cmd_cache = kmem_cache_create("scsi_tgt_cmd",
> -					       sizeof(struct
> scsi_tgt_cmd),
> -					       0, 0, NULL);
> +	scsi_tgt_cmd_cache =  KMEM_CACHE(scsi_tgt_cmd, 0);


Hi,

I have a question that is not described in your change log: why would
you want to do this change? kmem_cache_create() is THE linux API to
achieve this.... why would you not want to use it?? I'm sure you have a
good reason for this change, but I can't figure out what that is from
the changelog of your patch.

Greetings,
   Arjan van de Ven
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux